Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "apiclient" package #2486

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove "apiclient" package #2486

wants to merge 1 commit into from

Conversation

kruton
Copy link

@kruton kruton commented Sep 18, 2024

apiclient package was created in 2014 as a stop-gap to help people transition from "apiclient" to googleapiclient. This transition should have been completed in the past 10 years.

However now this is creating package pollution that interferes with another PyPI package called api-client that also writes to …/site-packages/apiclient/ and conflicts with this package.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2485 🦕

@kruton kruton requested review from yoshi-approver and a team as code owners September 18, 2024 01:00
@kruton kruton requested a review from dandhlee September 18, 2024 01:00
Copy link

google-cla bot commented Sep 18, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Sep 18, 2024
@parthea parthea removed their assignment Oct 25, 2024
"apiclient" was created in 2014 as a stop-gap to help people transition from
"apiclient" to "googleapiclient". This transition should have been completed in
the past 10 years.

However now this is creating package pollution that interferes with another PyPI
package called "api-client" that also writes to ".../site-packages/apiclient/"
and conflicts with this package.

BREAKING CHANGE: removes "apiclient" package which may still break those
who haven't transitioned.
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Dec 6, 2024
@kruton
Copy link
Author

kruton commented Dec 6, 2024

Rebased onto newest commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package writes to "apiclient" directory when installed
2 participants